New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
joh/inlineDiff2 #179965
Merged
Merged
joh/inlineDiff2 #179965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jrieken
commented
Apr 14, 2023
- wip live preview
- fix default width on first showing
- extract some parts into preview and live strategies
- update diff editor width on resize
- improve hidden area in diff editor
- full cancel when different model is set
- tweak colors of embedded diff editor (livePreview)
- support simple file create preview with live preview
- tweak action name
- use better diff editor options
- allow to pass widget options to embedded diff editor, don't create IE controller inside its nested editors ensure IE commands run from within nested diff editors
don't create IE controller inside its nested editors ensure IE commands run from within nested diff editors fixes microsoft/vscode-internalbacklog#3911
alexr00
previously approved these changes
Apr 14, 2023
src/vs/workbench/contrib/interactiveEditor/browser/interactiveEditorActions.ts
Show resolved
Hide resolved
alexr00
approved these changes
Apr 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.